-
Notifications
You must be signed in to change notification settings - Fork 2k
Hosting Dashboard: Fix glue records validation #106050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
9b92593 to
29029d7
Compare
| // TODO: Show the error via Data Form when the ValidatedInputControl component is ready. | ||
| <InputControl | ||
| __next40pxDefaultSize | ||
| <ValidatedInputControl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to apply changes to SuffixInputControl component, and then we can reuse it elsewhere 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! I've updated the component in db5a7d4.
Resolves DOTDASH-368
Proposed Changes
SuffixInputControlcomponent to use the newly exposedValidatedInputControl.As discussed here, this is using an experimental component, which may change in the future. This makes testing even more important, so I'm suggesting focusing on that next - DOTDASH-387.
Before:
After:
Why are these changes being made?
Testing Instructions
http://calypso.localhost:3000/v2/domains/[domain]/glue-records/addand try entering an invalid name server.Pre-merge Checklist